mirrors/cpython
1
0
Fork 0
mirror of https://github.com/python/cpython.git synced 2025-08-04 17:08:35 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 13

gh-129401: Test repr rlock failing randomly (#129959)

Browse source 
Fix and simplify a test of `test_repr_rlock` about multiprocessing.RLock primitive.
This commit is contained in:
Duprat 2025-03-01 21:28:14 +01:00 • committed by GitHub
parent 5326c27fc6
commit a98a6bd112
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
2 changed files with 8 additions and 13 deletions
Download patch file Download diff file Expand all files Collapse all files

20
Lib/test/_test_multiprocessing.py
View file

@ -1521,14 +1521,11 @@ class _TestLock(BaseTestCase):
for i in range(n):
self.assertIn(f'<RLock(MainProcess|T{i+1}, {i+1})>', l)
t = threading.Thread(target=self._acquire_release,
args=(lock, 0.2),
name=f'T1')
rlock = self.RLock()
t = threading.Thread(target=rlock.acquire)
t.start()
time.sleep(0.1)
self.assertEqual('<RLock(SomeOtherThread, nonzero)>', repr(lock))
time.sleep(0.2)
t.join()
self.assertEqual('<RLock(SomeOtherThread, nonzero)>', repr(rlock))
pname = 'P1'
l = multiprocessing.Manager().list()
@ -1539,14 +1536,11 @@ class _TestLock(BaseTestCase):
p.join()
self.assertEqual(f'<RLock({pname}, 1)>', l[0])
event = self.Event()
lock = self.RLock()
p = self.Process(target=self._acquire_event,
args=(lock, event))
rlock = self.RLock()
p = self.Process(target=self._acquire, args=(rlock,))
p.start()
event.wait()
self.assertEqual('<RLock(SomeOtherProcess, nonzero)>', repr(lock))
p.join()
self.assertEqual('<RLock(SomeOtherProcess, nonzero)>', repr(rlock))
def test_rlock(self):
lock = self.RLock()

1
Misc/NEWS.d/next/Tests/2025-02-10-14-34-29.gh-issue-129401.Cq6Ruy.rst Normal file
View file

@ -0,0 +1 @@
Fix a flaky test in ``test_repr_rlock`` that checks the representation of :class:`multiprocessing.RLock`.