mirrors/cpython
1
0
Fork 0
mirror of https://github.com/python/cpython.git synced 2025-08-31 05:58:33 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 7

Issue #15592. Fix regression: subprocess.communicate() breaks on no input with universal newlines true.

Browse source 
Patch by Chris Jerdonek.
This commit is contained in:
Andrew Svetlov 2012-08-14 18:40:21 +03:00
commit aa0dbdc2dd
2 changed files with 25 additions and 14 deletions
Download patch file Download diff file Expand all files Collapse all files

14
Lib/test/test_subprocess.py
View file

@ -615,8 +615,6 @@ class ProcessTestCase(BaseTestCase):
universal_newlines=1)
self.addCleanup(p.stdout.close)
self.addCleanup(p.stderr.close)
# BUG: can't give a non-empty stdin because it breaks both the
# select- and poll-based communicate() implementations.
(stdout, stderr) = p.communicate()
self.assertEqual(stdout,
"line2\nline4\nline5\nline6\nline7\nline8")
@ -635,6 +633,18 @@ class ProcessTestCase(BaseTestCase):
(stdout, stderr) = p.communicate("line1\nline3\n")
self.assertEqual(p.returncode, 0)
def test_universal_newlines_communicate_input_none(self):
# Test communicate(input=None) with universal newlines.
#
# We set stdout to PIPE because, as of this writing, a different
# code path is tested when the number of pipes is zero or one.
p = subprocess.Popen([sys.executable, "-c", "pass"],
stdin=subprocess.PIPE,
stdout=subprocess.PIPE,
universal_newlines=True)
p.communicate()
self.assertEqual(p.returncode, 0)
def test_no_leaking(self):
# Make sure we leak no resources
if not mswindows: