mirrors/cpython
1
0
Fork 0
mirror of https://github.com/python/cpython.git synced 2025-09-01 14:38:00 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 8

Issue #5113: Fix a test_posix failure on HP-UX, where non-root users can

Browse source 
chown() to root under certain circumstances.
This commit is contained in:
Charles-François Natali 2012-04-17 19:48:35 +02:00
parent 62930e1cc5
commit ab2d58eefa
1 changed files with 9 additions and 2 deletions
Download patch file Download diff file Expand all files Collapse all files

11
Lib/test/test_posix.py
View file

@ -9,6 +9,7 @@ import errno
import sys import sys
import time import time
import os import os
import platform
import pwd import pwd
import shutil import shutil
import stat import stat
@ -229,6 +230,9 @@ class PosixTester(unittest.TestCase):
def _test_all_chown_common(self, chown_func, first_param): def _test_all_chown_common(self, chown_func, first_param):
"""Common code for chown, fchown and lchown tests.""" """Common code for chown, fchown and lchown tests."""
# test a successful chown call
chown_func(first_param, os.getuid(), os.getgid())
if os.getuid() == 0: if os.getuid() == 0:
try: try:
# Many linux distros have a nfsnobody user as MAX_UID-2 # Many linux distros have a nfsnobody user as MAX_UID-2
@ -240,12 +244,15 @@ class PosixTester(unittest.TestCase):
chown_func(first_param, ent.pw_uid, ent.pw_gid) chown_func(first_param, ent.pw_uid, ent.pw_gid)
except KeyError: except KeyError:
pass pass
elif platform.system() in ('HP-UX', 'SunOS'):
# HP-UX and Solaris can allow a non-root user to chown() to root
# (issue #5113)
raise unittest.SkipTest("Skipping because of non-standard chown() "
"behavior")
else: else:
# non-root cannot chown to root, raises OSError # non-root cannot chown to root, raises OSError
self.assertRaises(OSError, chown_func, self.assertRaises(OSError, chown_func,
first_param, 0, 0) first_param, 0, 0)
# test a successful chown call
chown_func(first_param, os.getuid(), os.getgid())
@unittest.skipUnless(hasattr(posix, 'chown'), "test needs os.chown()") @unittest.skipUnless(hasattr(posix, 'chown'), "test needs os.chown()")
def test_chown(self): def test_chown(self):