mirrors/cpython
1
0
Fork 0
mirror of https://github.com/python/cpython.git synced 2025-08-31 05:58:33 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 7

Issue #21619: Popen objects no longer leave a zombie after exit in the with

Browse source 
statement if the pipe was broken.  Patch by Martin Panter.
This commit is contained in:
Serhiy Storchaka 2015-02-28 12:43:08 +02:00
parent fdde79dbf6
commit ab900c21fc
3 changed files with 24 additions and 4 deletions
Download patch file Download diff file Expand all files Collapse all files

10
Lib/subprocess.py
View file

@ -896,10 +896,12 @@ class Popen(object):
self.stdout.close()
if self.stderr:
self.stderr.close()
if self.stdin:
self.stdin.close()
# Wait for the process to terminate, to avoid zombies.
self.wait()
try: # Flushing a BufferedWriter may raise an error
if self.stdin:
self.stdin.close()
finally:
# Wait for the process to terminate, to avoid zombies.
self.wait()
def __del__(self, _maxsize=sys.maxsize):
if not self._child_created: