Issue #21619: Popen objects no longer leave a zombie after exit in the with

statement if the pipe was broken.  Patch by Martin Panter.
This commit is contained in:
Serhiy Storchaka 2015-02-28 12:43:08 +02:00
parent fdde79dbf6
commit ab900c21fc
3 changed files with 24 additions and 4 deletions

View file

@ -2521,6 +2521,21 @@ class ContextManagerTests(BaseTestCase):
stderr=subprocess.PIPE) as proc:
pass
def test_broken_pipe_cleanup(self):
"""Broken pipe error should not prevent wait() (Issue 21619)"""
proc = subprocess.Popen([sys.executable, "-c",
"import sys;"
"sys.stdin.close();"
"sys.stdout.close();" # Signals that input pipe is closed
], stdin=subprocess.PIPE, stdout=subprocess.PIPE)
proc.stdout.read() # Make sure subprocess has closed its input
proc.stdin.write(b"buffered data")
self.assertIsNone(proc.returncode)
self.assertRaises(BrokenPipeError, proc.__exit__, None, None, None)
self.assertEqual(0, proc.returncode)
self.assertTrue(proc.stdin.closed)
self.assertTrue(proc.stdout.closed)
def test_main():
unit_tests = (ProcessTestCase,