mirrors/cpython
1
0
Fork 0
mirror of https://github.com/python/cpython.git synced 2025-09-27 10:50:04 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 13

Don't use a sleep to wait for the server to be ready; this caused

Browse source 
problems on my OSX laptop.  use a condition variable instead.
This commit is contained in:
Guido van Rossum 2007-07-23 01:49:28 +00:00
parent d745c436fb
commit accecdf969
1 changed files with 5 additions and 3 deletions
Download patch file Download diff file Expand all files Collapse all files

8
Lib/test/test_poplib.py
View file

@ -7,12 +7,13 @@ from unittest import TestCase
from test import test_support from test import test_support
def server(evt): def server(ready, evt):
serv = socket.socket(socket.AF_INET, socket.SOCK_STREAM) serv = socket.socket(socket.AF_INET, socket.SOCK_STREAM)
serv.settimeout(3) serv.settimeout(3)
serv.setsockopt(socket.SOL_SOCKET, socket.SO_REUSEADDR, 1) serv.setsockopt(socket.SOL_SOCKET, socket.SO_REUSEADDR, 1)
serv.bind(("", 9091)) serv.bind(("", 9091))
serv.listen(5) serv.listen(5)
ready.set()
try: try:
conn, addr = serv.accept() conn, addr = serv.accept()
except socket.timeout: except socket.timeout:
@ -28,8 +29,9 @@ class GeneralTests(TestCase):
def setUp(self): def setUp(self):
self.evt = threading.Event() self.evt = threading.Event()
threading.Thread(target=server, args=(self.evt,)).start() self.ready = threading.Event()
time.sleep(.1) threading.Thread(target=server, args=(self.ready, self.evt,)).start()
self.ready.wait()
def tearDown(self): def tearDown(self):
self.evt.wait() self.evt.wait()