mirrors/cpython
1
0
Fork 0
mirror of https://github.com/python/cpython.git synced 2025-07-24 11:44:31 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 8

GH-104947: Make pathlib.PureWindowsPath comparisons consistent across platforms (GH-104948)

Browse source 
Use `str.lower()` rather than `ntpath.normcase()` to normalize case of
Windows paths. This restores behaviour from Python 3.11.

Co-authored-by: Gregory P. Smith <greg@krypto.org>
This commit is contained in:
Barney Gale 2023-05-26 19:04:02 +01:00 • committed by GitHub
parent 060277d96b
commit ad0be361c9
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
3 changed files with 7 additions and 1 deletions
Download patch file Download diff file Expand all files Collapse all files

5
Lib/pathlib.py
View file

@ -421,7 +421,10 @@ class PurePath(os.PathLike):
try: try:
return self._str_normcase_cached return self._str_normcase_cached
except AttributeError: except AttributeError:
self._str_normcase_cached = self._flavour.normcase(str(self)) if _is_case_sensitive(self._flavour):
self._str_normcase_cached = str(self)
else:
self._str_normcase_cached = str(self).lower()
return self._str_normcase_cached return self._str_normcase_cached
@property @property

1
Lib/test/test_pathlib.py
View file

@ -904,6 +904,7 @@ class PureWindowsPathTest(_BasePurePathTest, unittest.TestCase):
self.assertEqual(P('a/B'), P('A/b')) self.assertEqual(P('a/B'), P('A/b'))
self.assertEqual(P('C:a/B'), P('c:A/b')) self.assertEqual(P('C:a/B'), P('c:A/b'))
self.assertEqual(P('//Some/SHARE/a/B'), P('//somE/share/A/b')) self.assertEqual(P('//Some/SHARE/a/B'), P('//somE/share/A/b'))
self.assertEqual(P('\u0130'), P('i\u0307'))
def test_as_uri(self): def test_as_uri(self):
P = self.cls P = self.cls

2
Misc/NEWS.d/next/Library/2023-05-25-22-54-20.gh-issue-104947.hi6TUr.rst Normal file
View file

@ -0,0 +1,2 @@
Make comparisons between :class:`pathlib.PureWindowsPath` objects consistent
across Windows and Posix to match 3.11 behavior.