mirrors/cpython
1
0
Fork 0
mirror of https://github.com/python/cpython.git synced 2025-08-01 15:43:13 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 8

Bug #1500293: fix memory leaks in _subprocess module.

Browse source
This commit is contained in:
Georg Brandl 2006-06-04 22:15:37 +00:00
parent ddbaa660d3
commit ad62489e47
2 changed files with 15 additions and 8 deletions
Download patch file Download diff file Expand all files Collapse all files

13
PC/_subprocess.c
View file

@ -250,19 +250,23 @@ static int
getint(PyObject* obj, char* name)
{
PyObject* value;
int ret;
value = PyObject_GetAttrString(obj, name);
if (! value) {
PyErr_Clear(); /* FIXME: propagate error? */
return 0;
}
return (int) PyInt_AsLong(value);
ret = (int) PyInt_AsLong(value);
Py_DECREF(value);
return ret;
}
static HANDLE
gethandle(PyObject* obj, char* name)
{
sp_handle_object* value;
HANDLE ret;
value = (sp_handle_object*) PyObject_GetAttrString(obj, name);
if (! value) {
@ -270,8 +274,11 @@ gethandle(PyObject* obj, char* name)
return NULL;
}
if (value->ob_type != &sp_handle_type)
return NULL;
return value->handle;
ret = NULL;
else
ret = value->handle;
Py_DECREF(value);
return ret;
}
static PyObject*