mirrors/cpython
1
0
Fork 0
mirror of https://github.com/python/cpython.git synced 2025-10-05 06:31:48 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 8

bpo-43434: Move sqlite3.connect audit event to sqlite3.Connection.__init__ (GH-25818)

Browse source
This commit is contained in:
Erlend Egeberg Aasland 2021-05-03 00:43:06 +02:00 • committed by GitHub
parent e60b1e150d
commit ad73d1657c
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
3 changed files with 9 additions and 9 deletions
Download patch file Download diff file Expand all files Collapse all files

4
Misc/NEWS.d/next/Security/2021-05-02-17-50-23.bpo-43434.cy7xz6.rst Normal file
View file

@ -0,0 +1,4 @@
Creating a :class:`sqlite3.Connection` object now also produces
a ``sqlite3.connect`` :ref:`auditing event <auditing>`.
Previously this event was only produced by :func:`sqlite3.connect`
calls. Patch by Erlend E. Aasland.

4
Modules/_sqlite/connection.c
View file

@ -96,6 +96,10 @@ int pysqlite_connection_init(pysqlite_Connection* self, PyObject* args, PyObject
return -1; return -1;
} }
if (PySys_Audit("sqlite3.connect", "O", database_obj) < 0) {
return -1;
}
database = PyBytes_AsString(database_obj); database = PyBytes_AsString(database_obj);
self->initialized = 1; self->initialized = 1;

10
Modules/_sqlite/module.c
View file

@ -71,8 +71,6 @@ static PyObject* module_connect(PyObject* self, PyObject* args, PyObject*
int uri = 0; int uri = 0;
double timeout = 5.0; double timeout = 5.0;
PyObject* result;
if (!PyArg_ParseTupleAndKeywords(args, kwargs, "O|diOiOip", kwlist, if (!PyArg_ParseTupleAndKeywords(args, kwargs, "O|diOiOip", kwlist,
&database, &timeout, &detect_types, &database, &timeout, &detect_types,
&isolation_level, &check_same_thread, &isolation_level, &check_same_thread,
@ -85,13 +83,7 @@ static PyObject* module_connect(PyObject* self, PyObject* args, PyObject*
factory = (PyObject*)&pysqlite_ConnectionType; factory = (PyObject*)&pysqlite_ConnectionType;
} }
if (PySys_Audit("sqlite3.connect", "O", database) < 0) { return PyObject_Call(factory, args, kwargs);
return NULL;
}
result = PyObject_Call(factory, args, kwargs);
return result;
} }
PyDoc_STRVAR(module_connect_doc, PyDoc_STRVAR(module_connect_doc,