mirrors/cpython
1
0
Fork 0
mirror of https://github.com/python/cpython.git synced 2025-09-04 16:01:10 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 9

bpo-43423 Fix IndexError in subprocess _communicate function (GH-24777)

Browse source 
Check to make sure stdout and stderr are not empty before selecting an item from them in Windows subprocess._communicate.

Co-authored-by: Gregory P. Smith <greg@krypto.org>
(cherry picked from commit b4fc44bb2d)

Co-authored-by: Chris Griffith <chris@cdgriffith.com>
This commit is contained in:
Miss Islington (bot) 2021-03-11 17:56:35 -08:00 • committed by GitHub
parent 531f2ebd60
commit ad83fde754
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
2 changed files with 4 additions and 4 deletions
Download patch file Download diff file Expand all files Collapse all files

6
Lib/subprocess.py
View file

@ -1525,10 +1525,8 @@ class Popen(object):
self.stderr.close() self.stderr.close()
# All data exchanged. Translate lists into strings. # All data exchanged. Translate lists into strings.
if stdout is not None: stdout = stdout[0] if stdout else None
stdout = stdout[0] stderr = stderr[0] if stderr else None
if stderr is not None:
stderr = stderr[0]
return (stdout, stderr) return (stdout, stderr)

2
Misc/NEWS.d/next/Library/2021-03-11-15-44-18.bpo-43423.rRomRD.rst Normal file
View file

@ -0,0 +1,2 @@
:func:`subprocess.communicate` no longer raises an IndexError when there is an
empty stdout or stderr IO buffer during a timeout on Windows.