mirrors/cpython
1
0
Fork 0
mirror of https://github.com/python/cpython.git synced 2025-08-28 04:35:02 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 8

GH-102748: remove legacy support for generator based coroutines from asyncio.iscoroutine (#102749)

Browse source 
Co-authored-by: Alex Waygood <Alex.Waygood@Gmail.com>
This commit is contained in:
Kumar Aditya 2023-03-16 20:28:10 +05:30 • committed by GitHub
parent fbe82fdd77
commit adaed17341
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
4 changed files with 14 additions and 2 deletions
Download patch file Download diff file Expand all files Collapse all files

4
Doc/whatsnew/3.12.rst
View file

@ -237,6 +237,10 @@ asyncio
* Add C implementation of :func:`asyncio.current_task` for 4x-6x speedup. * Add C implementation of :func:`asyncio.current_task` for 4x-6x speedup.
(Contributed by Itamar Ostricher and Pranav Thulasiram Bhat in :gh:`100344`.) (Contributed by Itamar Ostricher and Pranav Thulasiram Bhat in :gh:`100344`.)
* :func:`asyncio.iscoroutine` now returns ``False`` for generators as
:mod:`asyncio` does not support legacy generator-based coroutines.
(Contributed by Kumar Aditya in :gh:`102748`.)
inspect inspect
------- -------

3
Lib/asyncio/coroutines.py
View file

@ -25,8 +25,7 @@ def iscoroutinefunction(func):
# Prioritize native coroutine check to speed-up # Prioritize native coroutine check to speed-up
# asyncio.iscoroutine. # asyncio.iscoroutine.
_COROUTINE_TYPES = (types.CoroutineType, types.GeneratorType, _COROUTINE_TYPES = (types.CoroutineType, collections.abc.Coroutine)
collections.abc.Coroutine)
_iscoroutine_typecache = set() _iscoroutine_typecache = set()

6
Lib/test/test_asyncio/test_pep492.py
View file

@ -119,6 +119,12 @@ class CoroutineTests(BaseTest):
self.assertTrue(asyncio.iscoroutine(FakeCoro())) self.assertTrue(asyncio.iscoroutine(FakeCoro()))
def test_iscoroutine_generator(self):
def foo(): yield
self.assertFalse(asyncio.iscoroutine(foo()))
def test_iscoroutinefunction(self): def test_iscoroutinefunction(self):
async def foo(): pass async def foo(): pass
self.assertTrue(asyncio.iscoroutinefunction(foo)) self.assertTrue(asyncio.iscoroutinefunction(foo))

3
Misc/NEWS.d/next/Library/2023-03-16-08-17-29.gh-issue-102748.WNACpI.rst Normal file
View file

@ -0,0 +1,3 @@
:func:`asyncio.iscoroutine` now returns ``False`` for generators as
:mod:`asyncio` does not support legacy generator-based coroutines.
Patch by Kumar Aditya.