gh-88965: typing: fix type substitution of a list of types after initial ParamSpec substitution (#102808)

Previously, this used to fail:

```py
from typing import *
T = TypeVar("T")
P = ParamSpec("P")

class X(Generic[P]):
    f: Callable[P, int]

Y = X[[int, T]]
Z = Y[str]
```

Co-authored-by: Alex Waygood <Alex.Waygood@Gmail.com>
This commit is contained in:
Nikita Sobolev 2023-03-23 19:26:11 +03:00 committed by GitHub
parent baf4eb083c
commit adb0621652
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
3 changed files with 154 additions and 7 deletions

View file

@ -7679,6 +7679,127 @@ class ParamSpecTests(BaseTestCase):
with self.assertRaises(TypeError):
collections.abc.Callable[P, T][arg, str]
def test_type_var_subst_for_other_type_vars(self):
T = TypeVar('T')
T2 = TypeVar('T2')
P = ParamSpec('P')
P2 = ParamSpec('P2')
Ts = TypeVarTuple('Ts')
class Base(Generic[P]):
pass
A1 = Base[T]
self.assertEqual(A1.__parameters__, (T,))
self.assertEqual(A1.__args__, ((T,),))
self.assertEqual(A1[int], Base[int])
A2 = Base[[T]]
self.assertEqual(A2.__parameters__, (T,))
self.assertEqual(A2.__args__, ((T,),))
self.assertEqual(A2[int], Base[int])
A3 = Base[[int, T]]
self.assertEqual(A3.__parameters__, (T,))
self.assertEqual(A3.__args__, ((int, T),))
self.assertEqual(A3[str], Base[[int, str]])
A4 = Base[[T, int, T2]]
self.assertEqual(A4.__parameters__, (T, T2))
self.assertEqual(A4.__args__, ((T, int, T2),))
self.assertEqual(A4[str, bool], Base[[str, int, bool]])
A5 = Base[[*Ts, int]]
self.assertEqual(A5.__parameters__, (Ts,))
self.assertEqual(A5.__args__, ((*Ts, int),))
self.assertEqual(A5[str, bool], Base[[str, bool, int]])
A5_2 = Base[[int, *Ts]]
self.assertEqual(A5_2.__parameters__, (Ts,))
self.assertEqual(A5_2.__args__, ((int, *Ts),))
self.assertEqual(A5_2[str, bool], Base[[int, str, bool]])
A6 = Base[[T, *Ts]]
self.assertEqual(A6.__parameters__, (T, Ts))
self.assertEqual(A6.__args__, ((T, *Ts),))
self.assertEqual(A6[int, str, bool], Base[[int, str, bool]])
A7 = Base[[T, T]]
self.assertEqual(A7.__parameters__, (T,))
self.assertEqual(A7.__args__, ((T, T),))
self.assertEqual(A7[int], Base[[int, int]])
A8 = Base[[T, list[T]]]
self.assertEqual(A8.__parameters__, (T,))
self.assertEqual(A8.__args__, ((T, list[T]),))
self.assertEqual(A8[int], Base[[int, list[int]]])
A9 = Base[[Tuple[*Ts], *Ts]]
self.assertEqual(A9.__parameters__, (Ts,))
self.assertEqual(A9.__args__, ((Tuple[*Ts], *Ts),))
self.assertEqual(A9[int, str], Base[Tuple[int, str], int, str])
A10 = Base[P2]
self.assertEqual(A10.__parameters__, (P2,))
self.assertEqual(A10.__args__, (P2,))
self.assertEqual(A10[[int, str]], Base[[int, str]])
class DoubleP(Generic[P, P2]):
pass
B1 = DoubleP[P, P2]
self.assertEqual(B1.__parameters__, (P, P2))
self.assertEqual(B1.__args__, (P, P2))
self.assertEqual(B1[[int, str], [bool]], DoubleP[[int, str], [bool]])
self.assertEqual(B1[[], []], DoubleP[[], []])
B2 = DoubleP[[int, str], P2]
self.assertEqual(B2.__parameters__, (P2,))
self.assertEqual(B2.__args__, ((int, str), P2))
self.assertEqual(B2[[bool, bool]], DoubleP[[int, str], [bool, bool]])
self.assertEqual(B2[[]], DoubleP[[int, str], []])
B3 = DoubleP[P, [bool, bool]]
self.assertEqual(B3.__parameters__, (P,))
self.assertEqual(B3.__args__, (P, (bool, bool)))
self.assertEqual(B3[[int, str]], DoubleP[[int, str], [bool, bool]])
self.assertEqual(B3[[]], DoubleP[[], [bool, bool]])
B4 = DoubleP[[T, int], [bool, T2]]
self.assertEqual(B4.__parameters__, (T, T2))
self.assertEqual(B4.__args__, ((T, int), (bool, T2)))
self.assertEqual(B4[str, float], DoubleP[[str, int], [bool, float]])
B5 = DoubleP[[*Ts, int], [bool, T2]]
self.assertEqual(B5.__parameters__, (Ts, T2))
self.assertEqual(B5.__args__, ((*Ts, int), (bool, T2)))
self.assertEqual(B5[str, bytes, float],
DoubleP[[str, bytes, int], [bool, float]])
B6 = DoubleP[[T, int], [bool, *Ts]]
self.assertEqual(B6.__parameters__, (T, Ts))
self.assertEqual(B6.__args__, ((T, int), (bool, *Ts)))
self.assertEqual(B6[str, bytes, float],
DoubleP[[str, int], [bool, bytes, float]])
class PandT(Generic[P, T]):
pass
C1 = PandT[P, T]
self.assertEqual(C1.__parameters__, (P, T))
self.assertEqual(C1.__args__, (P, T))
self.assertEqual(C1[[int, str], bool], PandT[[int, str], bool])
C2 = PandT[[int, T], T]
self.assertEqual(C2.__parameters__, (T,))
self.assertEqual(C2.__args__, ((int, T), T))
self.assertEqual(C2[str], PandT[[int, str], str])
C3 = PandT[[int, *Ts], T]
self.assertEqual(C3.__parameters__, (Ts, T))
self.assertEqual(C3.__args__, ((int, *Ts), T))
self.assertEqual(C3[str, bool, bytes], PandT[[int, str, bool], bytes])
def test_paramspec_in_nested_generics(self):
# Although ParamSpec should not be found in __parameters__ of most
# generics, they probably should be found when nested in