mirrors/cpython
1
0
Fork 0
mirror of https://github.com/python/cpython.git synced 2025-08-03 08:34:29 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 6

bpo-31084: QueueHandler now formats messages correctly. (GH-2954)

Browse source
This commit is contained in:
favll 2017-08-01 20:12:26 +02:00 • committed by Vinay Sajip
parent 6f446bee4f
commit adfe3440f6
2 changed files with 19 additions and 4 deletions
Download patch file Download diff file Expand all files Collapse all files

9
Lib/logging/handlers.py
View file

@ -1372,13 +1372,14 @@ class QueueHandler(logging.Handler):
of the record while leaving the original intact.
"""
# The format operation gets traceback text into record.exc_text
# (if there's exception data), and also puts the message into
# record.message. We can then use this to replace the original
# (if there's exception data), and also returns the formatted
# message. We can then use this to replace the original
# msg + args, as these might be unpickleable. We also zap the
# exc_info attribute, as it's no longer needed and, if not None,
# will typically not be pickleable.
self.format(record)
record.msg = record.message
msg = self.format(record)
record.message = msg
record.msg = msg
record.args = None
record.exc_info = None
return record