mirrors/cpython
1
0
Fork 0
mirror of https://github.com/python/cpython.git synced 2025-09-28 11:15:17 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 4

gh-104146: Purge dead code from Argument Clinic (#104680)

Browse source 
The following local variables were assigned but never used:

- line 551:  result
- line 1341: groups
- line 1431: default_return_converter
- line 1529: ignore_self
- line 1809: input_checksum
- line 4224: new'

---

Co-authored-by: Alex Waygood <Alex.Waygood@Gmail.com>
This commit is contained in:
Erlend E. Aasland 2023-05-20 12:52:32 +02:00 • committed by GitHub
parent 02b60035ce
commit ae147d01a0
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
1 changed files with 1 additions and 10 deletions
Download patch file Download diff file Expand all files Collapse all files

11
Tools/clinic/clinic.py
View file

@ -548,8 +548,6 @@ def permute_optional_groups(left, required, right):
If required is empty, left must also be empty. If required is empty, left must also be empty.
""" """
required = tuple(required) required = tuple(required)
result = []
if not required: if not required:
if left: if left:
raise ValueError("required is empty but left is not") raise ValueError("required is empty but left is not")
@ -1338,7 +1336,6 @@ class CLanguage(Language):
if isinstance(parameters[0].converter, self_converter): if isinstance(parameters[0].converter, self_converter):
del parameters[0] del parameters[0]
groups = []
group = None group = None
left = [] left = []
right = [] right = []
@ -1428,8 +1425,6 @@ class CLanguage(Language):
first_optional = len(selfless) first_optional = len(selfless)
positional = selfless and selfless[-1].is_positional_only() positional = selfless and selfless[-1].is_positional_only()
new_or_init = f.kind in (METHOD_NEW, METHOD_INIT) new_or_init = f.kind in (METHOD_NEW, METHOD_INIT)
default_return_converter = (not f.return_converter or
f.return_converter.type == 'PyObject *')
has_option_groups = False has_option_groups = False
# offset i by -1 because first_optional needs to ignore self # offset i by -1 because first_optional needs to ignore self
@ -1526,7 +1521,6 @@ class CLanguage(Language):
template_dict['return_value'] = data.return_value template_dict['return_value'] = data.return_value
# used by unpack tuple code generator # used by unpack tuple code generator
ignore_self = -1 if isinstance(converters[0], self_converter) else 0
unpack_min = first_optional unpack_min = first_optional
unpack_max = len(selfless) unpack_max = len(selfless)
template_dict['unpack_min'] = str(unpack_min) template_dict['unpack_min'] = str(unpack_min)
@ -1803,10 +1797,8 @@ class BlockParser:
if self.verify: if self.verify:
if 'input' in d: if 'input' in d:
checksum = d['output'] checksum = d['output']
input_checksum = d['input']
else: else:
checksum = d['checksum'] checksum = d['checksum']
input_checksum = None
computed = compute_checksum(output, len(checksum)) computed = compute_checksum(output, len(checksum))
if checksum != computed: if checksum != computed:
@ -4243,8 +4235,7 @@ class DSLParser:
fail("Insufficient Clinic version!\n Version: " + version + "\n Required: " + required) fail("Insufficient Clinic version!\n Version: " + version + "\n Required: " + required)
def directive_module(self, name): def directive_module(self, name):
fields = name.split('.') fields = name.split('.')[:-1]
new = fields.pop()
module, cls = self.clinic._module_and_class(fields) module, cls = self.clinic._module_and_class(fields)
if cls: if cls:
fail("Can't nest a module inside a class!") fail("Can't nest a module inside a class!")