bpo-44180: Fix edge cases in invalid assigment rules in the parser (GH-26283)

Browse source

The invalid assignment rules are very delicate since the parser can
easily raise an invalid assignment when a keyword argument is provided.
As they are very deep into the grammar tree, is very difficult to
specify in which contexts these rules can be used and in which don't.
For that, we need to use a different version of the rule that doesn't do
error checking in those situations where we don't want the rule to raise
(keyword arguments and generator expressions).

We also need to check if we are in left-recursive rule, as those can try
to eagerly advance the parser even if the parse will fail at the end of
the expression. Failing to do this allows the parser to start parsing a
call as a tuple and incorrectly identify a keyword argument as an
invalid assignment, before it realizes that it was not a tuple after all.
(cherry picked from commit c878a97968)

Co-authored-by: Pablo Galindo <Pablogsal@gmail.com>

...

This commit is contained in:

Miss Islington (bot) 2021-05-21 11:20:43 -07:00 • committed by GitHub

parent 150bc1f4aa

commit ae1732d461

No known key found for this signature in database

GPG key ID: 4AEE18F83AFDEB23

6 changed files with 2339 additions and 2076 deletions

Show all changes Ignore whitespace when comparing lines Ignore changes in amount of whitespace Ignore changes in whitespace at EOL

Download patch file Download diff file Expand all files Collapse all files

4352

Parser/parser.c

View file

File diff suppressed because it is too large Load diff