mirror of
https://github.com/python/cpython.git
synced 2025-07-12 05:45:15 +00:00
[3.11] gh-68163: Correct conversion of Rational instances to float (GH-25619) (#96556)
Co-authored-by: Mark Dickinson <dickinsm@gmail.com> Co-authored-by: Sergey B Kirpichev <skirpichev@gmail.com>
This commit is contained in:
parent
e72f469e85
commit
ae819ca6fd
4 changed files with 36 additions and 4 deletions
|
@ -14,6 +14,27 @@ from fractions import Fraction as F
|
|||
_PyHASH_MODULUS = sys.hash_info.modulus
|
||||
_PyHASH_INF = sys.hash_info.inf
|
||||
|
||||
|
||||
class DummyIntegral(int):
|
||||
"""Dummy Integral class to test conversion of the Rational to float."""
|
||||
|
||||
def __mul__(self, other):
|
||||
return DummyIntegral(super().__mul__(other))
|
||||
__rmul__ = __mul__
|
||||
|
||||
def __truediv__(self, other):
|
||||
return NotImplemented
|
||||
__rtruediv__ = __truediv__
|
||||
|
||||
@property
|
||||
def numerator(self):
|
||||
return DummyIntegral(self)
|
||||
|
||||
@property
|
||||
def denominator(self):
|
||||
return DummyIntegral(1)
|
||||
|
||||
|
||||
class HashTest(unittest.TestCase):
|
||||
def check_equal_hash(self, x, y):
|
||||
# check both that x and y are equal and that their hashes are equal
|
||||
|
@ -121,6 +142,13 @@ class HashTest(unittest.TestCase):
|
|||
self.assertEqual(hash(F(7*_PyHASH_MODULUS, 1)), 0)
|
||||
self.assertEqual(hash(F(-_PyHASH_MODULUS, 1)), 0)
|
||||
|
||||
# The numbers ABC doesn't enforce that the "true" division
|
||||
# of integers produces a float. This tests that the
|
||||
# Rational.__float__() method has required type conversions.
|
||||
x = F(DummyIntegral(1), DummyIntegral(2), _normalize=False)
|
||||
self.assertRaises(TypeError, lambda: x.numerator/x.denominator)
|
||||
self.assertEqual(float(x), 0.5)
|
||||
|
||||
def test_hash_normalization(self):
|
||||
# Test for a bug encountered while changing long_hash.
|
||||
#
|
||||
|
|
Loading…
Add table
Add a link
Reference in a new issue