mirror of
https://github.com/python/cpython.git
synced 2025-08-03 16:39:00 +00:00
gh-79009: sqlite3.iterdump now correctly handles tables with autoincrement (#9621)
Co-authored-by: Erlend E. Aasland <erlend.aasland@protonmail.com>
This commit is contained in:
parent
8e08978141
commit
affa9f22cf
4 changed files with 62 additions and 1 deletions
|
@ -2,6 +2,8 @@
|
|||
|
||||
import unittest
|
||||
import sqlite3 as sqlite
|
||||
from .test_dbapi import memory_database
|
||||
|
||||
|
||||
class DumpTests(unittest.TestCase):
|
||||
def setUp(self):
|
||||
|
@ -49,6 +51,51 @@ class DumpTests(unittest.TestCase):
|
|||
[self.assertEqual(expected_sqls[i], actual_sqls[i])
|
||||
for i in range(len(expected_sqls))]
|
||||
|
||||
def test_dump_autoincrement(self):
|
||||
expected = [
|
||||
'CREATE TABLE "t1" (id integer primary key autoincrement);',
|
||||
'INSERT INTO "t1" VALUES(NULL);',
|
||||
'CREATE TABLE "t2" (id integer primary key autoincrement);',
|
||||
]
|
||||
self.cu.executescript("".join(expected))
|
||||
|
||||
# the NULL value should now be automatically be set to 1
|
||||
expected[1] = expected[1].replace("NULL", "1")
|
||||
expected.insert(0, "BEGIN TRANSACTION;")
|
||||
expected.extend([
|
||||
'DELETE FROM "sqlite_sequence";',
|
||||
'INSERT INTO "sqlite_sequence" VALUES(\'t1\',1);',
|
||||
'COMMIT;',
|
||||
])
|
||||
|
||||
actual = [stmt for stmt in self.cx.iterdump()]
|
||||
self.assertEqual(expected, actual)
|
||||
|
||||
def test_dump_autoincrement_create_new_db(self):
|
||||
self.cu.execute("BEGIN TRANSACTION")
|
||||
self.cu.execute("CREATE TABLE t1 (id integer primary key autoincrement)")
|
||||
self.cu.execute("CREATE TABLE t2 (id integer primary key autoincrement)")
|
||||
self.cu.executemany("INSERT INTO t1 VALUES(?)", ((None,) for _ in range(9)))
|
||||
self.cu.executemany("INSERT INTO t2 VALUES(?)", ((None,) for _ in range(4)))
|
||||
self.cx.commit()
|
||||
|
||||
with memory_database() as cx2:
|
||||
query = "".join(self.cx.iterdump())
|
||||
cx2.executescript(query)
|
||||
cu2 = cx2.cursor()
|
||||
|
||||
dataset = (
|
||||
("t1", 9),
|
||||
("t2", 4),
|
||||
)
|
||||
for table, seq in dataset:
|
||||
with self.subTest(table=table, seq=seq):
|
||||
res = cu2.execute("""
|
||||
SELECT "seq" FROM "sqlite_sequence" WHERE "name" == ?
|
||||
""", (table,))
|
||||
rows = res.fetchall()
|
||||
self.assertEqual(rows[0][0], seq)
|
||||
|
||||
def test_unorderable_row(self):
|
||||
# iterdump() should be able to cope with unorderable row types (issue #15545)
|
||||
class UnorderableRow:
|
||||
|
|
Loading…
Add table
Add a link
Reference in a new issue