mirror of
https://github.com/python/cpython.git
synced 2025-08-03 16:39:00 +00:00
Replace BadInternalCall with TypeError. Add a test case. Fix whitespace.
Just van Rossum showed a weird, but clever way for pure python code to trigger the BadInternalCall. The C code had assumed that calling a class constructor would return an instance of that class; however, classes that abuse __new__ can invalidate that assumption.
This commit is contained in:
parent
21d77f5e9c
commit
b02bb5ed0a
2 changed files with 10 additions and 2 deletions
|
@ -558,6 +558,13 @@ if type(dictlike.fromkeys('a')) is not dictlike:
|
|||
raise TestFailed, 'dictsubclass.fromkeys created wrong type'
|
||||
if type(dictlike().fromkeys('a')) is not dictlike:
|
||||
raise TestFailed, 'dictsubclass.fromkeys created wrong type'
|
||||
from UserDict import UserDict
|
||||
class mydict(dict):
|
||||
def __new__(cls, *args, **kwargs):
|
||||
return UserDict(*args, **kwargs)
|
||||
try: mydict.fromkeys('a b c'.split())
|
||||
except TypeError: pass
|
||||
else: raise TestFailed, 'dict.fromkeys() failed to detect non-dict class.'
|
||||
# dict.copy()
|
||||
d = {1:1, 2:2, 3:3}
|
||||
if d.copy() != {1:1, 2:2, 3:3}: raise TestFailed, 'dict copy'
|
||||
|
|
Loading…
Add table
Add a link
Reference in a new issue