mirrors/cpython
1
0
Fork 0
mirror of https://github.com/python/cpython.git synced 2025-08-03 16:39:00 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 8

Replace BadInternalCall with TypeError. Add a test case. Fix whitespace.

Browse source 
Just van Rossum showed a weird, but clever way for pure python code to
trigger the BadInternalCall.  The C code had assumed that calling a class
constructor would return an instance of that class; however, classes that
abuse __new__ can invalidate that assumption.
This commit is contained in:
Raymond Hettinger 2002-12-04 07:32:25 +00:00
parent 21d77f5e9c
commit b02bb5ed0a
2 changed files with 10 additions and 2 deletions
Download patch file Download diff file Expand all files Collapse all files

5
Objects/dictobject.c
View file

@ -973,15 +973,16 @@ dict_fromkeys(PyObject *mp, PyObject *args)
PyObject *cls;
int status;
if (!PyArg_ParseTuple(args, "OO|O:fromkeys", &cls, &seq, &value))
if (!PyArg_ParseTuple(args, "OO|O:fromkeys", &cls, &seq, &value))
return NULL;
d = PyObject_CallObject(cls, NULL);
if (d == NULL)
return NULL;
if (!PyDict_Check(d)) {
PyErr_BadInternalCall();
Py_DECREF(d);
PyErr_SetString(PyExc_TypeError,
"class constructor must return a subclass of dict");
return NULL;
}