mirrors/cpython
1
0
Fork 0
mirror of https://github.com/python/cpython.git synced 2025-07-24 11:44:31 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 8

bpo-44904: Fix classmethod property bug in doctest module (GH-28838)

Browse source 
The doctest module raised an error if a docstring contained an example that
attempted to access a classmethod property. (Stacking '@classmethod' on top of
`@property` has been supported since Python 3.9; see
https://docs.python.org/3/howto/descriptor.html#class-methods.)

Co-authored-by: Serhiy Storchaka <storchaka@gmail.com>
This commit is contained in:
Alex Waygood 2021-10-28 08:48:02 +01:00 • committed by GitHub
parent d02ffd1b5c
commit b1302abcc8
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
4 changed files with 21 additions and 4 deletions
Download patch file Download diff file Expand all files Collapse all files

15
Lib/test/test_doctest.py
View file

@ -96,6 +96,17 @@ class SampleClass:
22
""")
a_class_attribute = 42
@classmethod
@property
def a_classmethod_property(cls):
"""
>>> print(SampleClass.a_classmethod_property)
42
"""
return cls.a_class_attribute
class NestedClass:
"""
>>> x = SampleClass.NestedClass(5)
@ -501,6 +512,7 @@ methods, classmethods, staticmethods, properties, and nested classes.
1 SampleClass.NestedClass.__init__
1 SampleClass.__init__
2 SampleClass.a_classmethod
1 SampleClass.a_classmethod_property
1 SampleClass.a_property
1 SampleClass.a_staticmethod
1 SampleClass.double
@ -556,6 +568,7 @@ functions, classes, and the `__test__` dictionary, if it exists:
1 some_module.SampleClass.NestedClass.__init__
1 some_module.SampleClass.__init__
2 some_module.SampleClass.a_classmethod
1 some_module.SampleClass.a_classmethod_property
1 some_module.SampleClass.a_property
1 some_module.SampleClass.a_staticmethod
1 some_module.SampleClass.double
@ -597,6 +610,7 @@ By default, an object with no doctests doesn't create any tests:
1 SampleClass.NestedClass.__init__
1 SampleClass.__init__
2 SampleClass.a_classmethod
1 SampleClass.a_classmethod_property
1 SampleClass.a_property
1 SampleClass.a_staticmethod
1 SampleClass.double
@ -617,6 +631,7 @@ displays.
0 SampleClass.NestedClass.square
1 SampleClass.__init__
2 SampleClass.a_classmethod
1 SampleClass.a_classmethod_property
1 SampleClass.a_property
1 SampleClass.a_staticmethod
1 SampleClass.double