mirrors/cpython
1
0
Fork 0
mirror of https://github.com/python/cpython.git synced 2025-09-08 01:41:19 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 8

gh-129533: Update PyGC_Enable/Disable/IsEnabled to use atomic operation (gh-129563)

Browse source
This commit is contained in:
Donghee Na 2025-02-07 07:41:13 +09:00 • committed by GitHub
parent 4e3330f054
commit b184abf074
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
2 changed files with 10 additions and 11 deletions
Download patch file Download diff file Expand all files Collapse all files

3
Misc/NEWS.d/next/C_API/2025-02-02-12-58-21.gh-issue-129533.dFfqkT.rst Normal file
View file

@ -0,0 +1,3 @@
Update :c:func:`PyGC_Enable()`, :c:func:`PyGC_Disable()`,
:c:func:`PyGC_IsEnabled()` to use atomic operation for thread-safety
at free-threading build. Patch by Donghee Na.

18
Python/gc_free_threading.c
View file

@ -1864,7 +1864,8 @@ gc_should_collect(GCState *gcstate)
{ {
int count = _Py_atomic_load_int_relaxed(&gcstate->young.count); int count = _Py_atomic_load_int_relaxed(&gcstate->young.count);
int threshold = gcstate->young.threshold; int threshold = gcstate->young.threshold;
if (count <= threshold || threshold == 0 || !gcstate->enabled) { int gc_enabled = _Py_atomic_load_int_relaxed(&gcstate->enabled);
if (count <= threshold || threshold == 0 || !gc_enabled) {
return false; return false;
} }
// Avoid quadratic behavior by scaling threshold to the number of live // Avoid quadratic behavior by scaling threshold to the number of live
@ -2340,25 +2341,21 @@ int
PyGC_Enable(void) PyGC_Enable(void)
{ {
GCState *gcstate = get_gc_state(); GCState *gcstate = get_gc_state();
int old_state = gcstate->enabled; return _Py_atomic_exchange_int(&gcstate->enabled, 1);
gcstate->enabled = 1;
return old_state;
} }
int int
PyGC_Disable(void) PyGC_Disable(void)
{ {
GCState *gcstate = get_gc_state(); GCState *gcstate = get_gc_state();
int old_state = gcstate->enabled; return _Py_atomic_exchange_int(&gcstate->enabled, 0);
gcstate->enabled = 0;
return old_state;
} }
int int
PyGC_IsEnabled(void) PyGC_IsEnabled(void)
{ {
GCState *gcstate = get_gc_state(); GCState *gcstate = get_gc_state();
return gcstate->enabled; return _Py_atomic_load_int_relaxed(&gcstate->enabled);
} }
/* Public API to invoke gc.collect() from C */ /* Public API to invoke gc.collect() from C */
@ -2368,7 +2365,7 @@ PyGC_Collect(void)
PyThreadState *tstate = _PyThreadState_GET(); PyThreadState *tstate = _PyThreadState_GET();
GCState *gcstate = &tstate->interp->gc; GCState *gcstate = &tstate->interp->gc;
if (!gcstate->enabled) { if (!_Py_atomic_load_int_relaxed(&gcstate->enabled)) {
return 0; return 0;
} }
@ -2527,8 +2524,7 @@ _PyObject_GC_Link(PyObject *op)
void void
_Py_RunGC(PyThreadState *tstate) _Py_RunGC(PyThreadState *tstate)
{ {
GCState *gcstate = get_gc_state(); if (!PyGC_IsEnabled()) {
if (!gcstate->enabled) {
return; return;
} }
gc_collect_main(tstate, 0, _Py_GC_REASON_HEAP); gc_collect_main(tstate, 0, _Py_GC_REASON_HEAP);