mirrors/cpython
1
0
Fork 0
mirror of https://github.com/python/cpython.git synced 2025-09-27 10:50:04 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 13

[3.12] gh-105375: Improve _decimal error handling (GH-105605) (#105647)

Browse source 
Fix a bug where an exception could end up being overwritten.
(cherry picked from commit c932f72849)

Co-authored-by: Erlend E. Aasland <erlend.aasland@protonmail.com>
This commit is contained in:
Miss Islington (bot) 2023-06-11 03:55:18 -07:00 • committed by GitHub
parent 36ecbc3570
commit b4b5565e47
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
2 changed files with 6 additions and 1 deletions
Download patch file Download diff file Expand all files Collapse all files

1
Misc/NEWS.d/next/Library/2023-06-09-22-52-45.gh-issue-105375.6igkhn.rst Normal file
View file

@ -0,0 +1 @@
Fix bug in :mod:`decimal` where an exception could end up being overwritten.

6
Modules/_decimal/_decimal.c
View file

@ -3615,9 +3615,13 @@ dec_as_integer_ratio(PyObject *self, PyObject *args UNUSED)
goto error; goto error;
} }
Py_SETREF(numerator, _py_long_floor_divide(numerator, tmp)); Py_SETREF(numerator, _py_long_floor_divide(numerator, tmp));
if (numerator == NULL) {
Py_DECREF(tmp);
goto error;
}
Py_SETREF(denominator, _py_long_floor_divide(denominator, tmp)); Py_SETREF(denominator, _py_long_floor_divide(denominator, tmp));
Py_DECREF(tmp); Py_DECREF(tmp);
if (numerator == NULL || denominator == NULL) { if (denominator == NULL) {
goto error; goto error;
} }
} }