Add the command line to the AssertionError raised by test.script_helper's

Python subprocess failure assertion error messages for easier debugging.

Adds a unittest for test.script_helper to confirm that this code works as
it is otherwise uncovered by an already passing test suite that uses it. :)
This commit is contained in:
Gregory P. Smith 2015-01-20 17:19:47 -08:00
parent b176d40398
commit b5684c48e1
2 changed files with 38 additions and 2 deletions

View file

@ -51,8 +51,9 @@ def _assert_python(expected_success, *args, **env_vars):
err = strip_python_stderr(err)
if (rc and expected_success) or (not rc and not expected_success):
raise AssertionError(
"Process return code is %d, "
"stderr follows:\n%s" % (rc, err.decode('ascii', 'ignore')))
"Process return code is %d, command line was: %r, "
"stderr follows:\n%s" % (rc, cmd_line,
err.decode('ascii', 'ignore')))
return rc, out, err
def assert_python_ok(*args, **env_vars):