mirrors/cpython
1
0
Fork 0
mirror of https://github.com/python/cpython.git synced 2025-08-17 15:21:26 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 8

Fix closes issue12698 - make the no_proxy environment variable handling a bit lenient (accomodate spaces in between the items)

Browse source
This commit is contained in:
Senthil Kumaran 2011-08-06 12:24:33 +08:00
parent 0f8acebd53
commit b5bd4c88b5
2 changed files with 5 additions and 1 deletions
Download patch file Download diff file Expand all files Collapse all files

3
Lib/test/test_urllib.py
View file

@ -114,6 +114,9 @@ class ProxyTests(unittest.TestCase):
proxies = urllib.getproxies_environment() proxies = urllib.getproxies_environment()
# getproxies_environment use lowered case truncated (no '_proxy') keys # getproxies_environment use lowered case truncated (no '_proxy') keys
self.assertEqual('localhost', proxies['no']) self.assertEqual('localhost', proxies['no'])
# List of no_proxies with space.
self.env.set('NO_PROXY', 'localhost, anotherdomain.com, newdomain.com')
self.assertTrue(urllib.proxy_bypass_environment('anotherdomain.com'))
class urlopen_HttpTests(unittest.TestCase): class urlopen_HttpTests(unittest.TestCase):

3
Lib/urllib.py
View file

@ -1366,7 +1366,8 @@ def proxy_bypass_environment(host):
# strip port off host # strip port off host
hostonly, port = splitport(host) hostonly, port = splitport(host)
# check if the host ends with any of the DNS suffixes # check if the host ends with any of the DNS suffixes
for name in no_proxy.split(','): no_proxy_list = [proxy.strip() for proxy in no_proxy.split(',')]
for name in no_proxy_list:
if name and (hostonly.endswith(name) or host.endswith(name)): if name and (hostonly.endswith(name) or host.endswith(name)):
return 1 return 1
# otherwise, don't bypass # otherwise, don't bypass