mirrors/cpython
1
0
Fork 0
mirror of https://github.com/python/cpython.git synced 2025-11-08 05:39:34 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 8

SF patch #798534: Windows os.popen needlessly gets a reference to tuple ()

Browse source 
(Contributed by Andrew Gaul.)

Fixes a minor leak.
This commit is contained in:
Raymond Hettinger 2003-09-01 22:25:41 +00:00
parent 14cc1e3222
commit b5cb66542d
1 changed files with 1 additions and 3 deletions
Download patch file Download diff file Expand all files Collapse all files

4
Modules/posixmodule.c
View file

@ -3615,7 +3615,7 @@ static PyObject *_PyPopenProcs = NULL;
static PyObject * static PyObject *
posix_popen(PyObject *self, PyObject *args) posix_popen(PyObject *self, PyObject *args)
{ {
PyObject *f, *s; PyObject *f;
int tm = 0; int tm = 0;
char *cmdstring; char *cmdstring;
@ -3624,8 +3624,6 @@ posix_popen(PyObject *self, PyObject *args)
if (!PyArg_ParseTuple(args, "s|si:popen", &cmdstring, &mode, &bufsize)) if (!PyArg_ParseTuple(args, "s|si:popen", &cmdstring, &mode, &bufsize))
return NULL; return NULL;
s = PyTuple_New(0);
if (*mode == 'r') if (*mode == 'r')
tm = _O_RDONLY; tm = _O_RDONLY;
else if (*mode != 'w') { else if (*mode != 'w') {