mirrors/cpython
1
0
Fork 0
mirror of https://github.com/python/cpython.git synced 2025-08-31 14:07:50 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 9

Make array().tofile() work with a new I/O object.

Browse source
This commit is contained in:
Guido van Rossum 2007-04-11 17:08:28 +00:00
parent d0712817ac
commit b5ddcfd2a2
2 changed files with 30 additions and 6 deletions
Download patch file Download diff file Expand all files Collapse all files

2
Lib/test/test_array.py
View file

@ -147,7 +147,7 @@ class BaseTest(unittest.TestCase):
def test_tofromfile(self): def test_tofromfile(self):
a = array.array(self.typecode, 2*self.example) a = array.array(self.typecode, 2*self.example)
self.assertRaises(TypeError, a.tofile) self.assertRaises(TypeError, a.tofile)
self.assertRaises(TypeError, a.tofile, cStringIO.StringIO()) ##self.assertRaises(TypeError, a.tofile, cStringIO.StringIO())
f = open(test_support.TESTFN, 'wb') f = open(test_support.TESTFN, 'wb')
try: try:
a.tofile(f) a.tofile(f)

34
Modules/arraymodule.c
View file

@ -1252,12 +1252,11 @@ array_tofile(arrayobject *self, PyObject *f)
{ {
FILE *fp; FILE *fp;
if (self->ob_size == 0)
goto done;
fp = PyFile_AsFile(f); fp = PyFile_AsFile(f);
if (fp == NULL) { if (fp != NULL) {
PyErr_SetString(PyExc_TypeError, "arg must be open file");
return NULL;
}
if (self->ob_size > 0) {
if (fwrite(self->ob_item, self->ob_descr->itemsize, if (fwrite(self->ob_item, self->ob_descr->itemsize,
self->ob_size, fp) != (size_t)self->ob_size) { self->ob_size, fp) != (size_t)self->ob_size) {
PyErr_SetFromErrno(PyExc_IOError); PyErr_SetFromErrno(PyExc_IOError);
@ -1265,6 +1264,31 @@ array_tofile(arrayobject *self, PyObject *f)
return NULL; return NULL;
} }
} }
else {
Py_ssize_t nbytes = self->ob_size * self->ob_descr->itemsize;
/* Write 64K blocks at a time */
/* XXX Make the block size settable */
int BLOCKSIZE = 64*1024;
Py_ssize_t nblocks = (nbytes + BLOCKSIZE - 1) / BLOCKSIZE;
Py_ssize_t i;
for (i = 0; i < nblocks; i++) {
char* ptr = self->ob_item + i*BLOCKSIZE;
Py_ssize_t size = BLOCKSIZE;
PyObject *bytes, *res;
if (i*BLOCKSIZE + size > nbytes)
size = nbytes - i*BLOCKSIZE;
bytes = PyBytes_FromStringAndSize(ptr, size);
if (bytes == NULL)
return NULL;
res = PyObject_CallMethod(f, "write", "O",
bytes);
Py_DECREF(bytes);
if (res == NULL)
return NULL;
}
}
done:
Py_INCREF(Py_None); Py_INCREF(Py_None);
return Py_None; return Py_None;
} }