mirrors/cpython
1
0
Fork 0
mirror of https://github.com/python/cpython.git synced 2025-07-30 06:34:15 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 8

#2560: remove an unnecessary 'for' loop from my_fgets() in Parser/myreadline.c.

Browse source 
Noted by Joseph Armbruster; patch by Jessica McKellar.

The original code was 'for (;;) {...}', where ... ended
with a 'return -2' statement and did not contain a 'break' or 'continue'
statement.  Therefore, the body of the loop is always executed once.

Once upon a time there was a 'continue' in the loop, but it was removed in
rev36346, committed by mwh on Wed Jul 7 17:44:12 2004.
This commit is contained in:
Andrew M. Kuchling 2010-02-22 22:48:41 +00:00
parent 5cac46dd41
commit b64d61369a
2 changed files with 54 additions and 54 deletions
Download patch file Download diff file Expand all files Collapse all files

3
Misc/NEWS
View file

@ -12,6 +12,9 @@ What's New in Python 2.7 alpha 4?
Core and Builtins Core and Builtins
----------------- -----------------
- Issue #2560: remove an unnecessary 'for' loop from my_fgets() in
Parser/myreadline.c.
- Issue #7988: Fix default alignment to be right aligned for - Issue #7988: Fix default alignment to be right aligned for
complex.__format__. Now it matches other numeric types. complex.__format__. Now it matches other numeric types.

3
Parser/myreadline.c
View file

@ -40,7 +40,6 @@ static int
my_fgets(char *buf, int len, FILE *fp) my_fgets(char *buf, int len, FILE *fp)
{ {
char *p; char *p;
for (;;) {
if (PyOS_InputHook != NULL) if (PyOS_InputHook != NULL)
(void)(PyOS_InputHook)(); (void)(PyOS_InputHook)();
errno = 0; errno = 0;
@ -98,8 +97,6 @@ my_fgets(char *buf, int len, FILE *fp)
return 1; /* Interrupt */ return 1; /* Interrupt */
} }
return -2; /* Error */ return -2; /* Error */
}
/* NOTREACHED */
} }