merge heads

This commit is contained in:
Benjamin Peterson 2012-07-31 21:50:11 -07:00
commit b685d19eb3
2 changed files with 10 additions and 10 deletions

View file

@ -232,17 +232,14 @@ class UnixBrowser(BaseBrowser):
stdout=(self.redirect_stdout and inout or None), stdout=(self.redirect_stdout and inout or None),
stderr=inout, start_new_session=True) stderr=inout, start_new_session=True)
if remote: if remote:
# wait five seconds. If the subprocess is not finished, the # wait at most five seconds. If the subprocess is not finished, the
# remote invocation has (hopefully) started a new instance. # remote invocation has (hopefully) started a new instance.
time.sleep(1) try:
rc = p.poll() rc = p.wait(5)
if rc is None:
time.sleep(4)
rc = p.poll()
if rc is None:
return True
# if remote call failed, open() will try direct invocation # if remote call failed, open() will try direct invocation
return not rc return not rc
except subprocess.TimeoutExpired:
return True
elif self.background: elif self.background:
if p.poll() is None: if p.poll() is None:
return True return True

View file

@ -72,6 +72,9 @@ Core and Builtins
Library Library
------- -------
- Issue #15499: Launching a webbrowser in Unix used to sleep for a few
seconds. Original patch by Anton Barkovsky.
- Issue #15463: the faulthandler module truncates strings to 500 characters, - Issue #15463: the faulthandler module truncates strings to 500 characters,
instead of 100, to be able to display long file paths instead of 100, to be able to display long file paths