bpo-43797: Improve syntax error for invalid comparisons (#25317)

* bpo-43797: Improve syntax error for invalid comparisons

* Update Lib/test/test_fstring.py

Co-authored-by: Guido van Rossum <gvanrossum@gmail.com>

* Apply review comments

* can't -> cannot

Co-authored-by: Guido van Rossum <gvanrossum@gmail.com>
This commit is contained in:
Pablo Galindo 2021-04-12 16:59:30 +01:00 committed by GitHub
parent 2459b92a4d
commit b86ed8e3bb
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
12 changed files with 1375 additions and 779 deletions

File diff suppressed because it is too large Load diff

View file

@ -147,8 +147,8 @@ byte_offset_to_character_offset(PyObject *line, Py_ssize_t col_offset)
return 0;
}
Py_ssize_t len = strlen(str);
if (col_offset > len) {
col_offset = len;
if (col_offset > len + 1) {
col_offset = len + 1;
}
assert(col_offset >= 0);
PyObject *text = PyUnicode_DecodeUTF8(str, col_offset, "replace");
@ -184,7 +184,7 @@ _PyPegen_get_expr_name(expr_ty e)
case BoolOp_kind:
case BinOp_kind:
case UnaryOp_kind:
return "operator";
return "expression";
case GeneratorExp_kind:
return "generator expression";
case Yield_kind:
@ -199,7 +199,7 @@ _PyPegen_get_expr_name(expr_ty e)
case DictComp_kind:
return "dict comprehension";
case Dict_kind:
return "dict display";
return "dict literal";
case Set_kind:
return "set display";
case JoinedStr_kind: