mirror of
https://github.com/python/cpython.git
synced 2025-08-04 08:59:19 +00:00
bpo-42392: Improve removal of *loop* parameter in asyncio primitives (GH-23499)
* Update code after merge review from 1st1 * Use a sentinel approach for loop parameter Remove unnecessary _get_running_loop patching * Use more clear function name (_verify_parameter_is_marker -> _verify_no_loop) * Add init method to _LoopBoundMixin to check that loop param wasn't used
This commit is contained in:
parent
7301979b23
commit
b9127dd6ee
5 changed files with 46 additions and 35 deletions
|
@ -5,10 +5,20 @@ from . import events
|
|||
|
||||
_global_lock = threading.Lock()
|
||||
|
||||
# Used as a sentinel for loop parameter
|
||||
_marker = object()
|
||||
|
||||
class _LoopBoundedMixin:
|
||||
|
||||
class _LoopBoundMixin:
|
||||
_loop = None
|
||||
|
||||
def __init__(self, *, loop=_marker):
|
||||
if loop is not _marker:
|
||||
raise TypeError(
|
||||
f'As of 3.10, the *loop* parameter was removed from '
|
||||
f'{type(self).__name__}() since it is no longer necessary'
|
||||
)
|
||||
|
||||
def _get_loop(self):
|
||||
loop = events._get_running_loop()
|
||||
|
||||
|
@ -17,5 +27,5 @@ class _LoopBoundedMixin:
|
|||
if self._loop is None:
|
||||
self._loop = loop
|
||||
if loop is not self._loop:
|
||||
raise RuntimeError(f'{type(self).__name__} have already bounded to another loop')
|
||||
raise RuntimeError(f'{self!r} is bound to a different event loop')
|
||||
return loop
|
||||
|
|
Loading…
Add table
Add a link
Reference in a new issue