mirrors/cpython
1
0
Fork 0
mirror of https://github.com/python/cpython.git synced 2025-08-04 00:48:58 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 8

bpo-38698: Prevent UnboundLocalError to pop up in parse_message_id (GH-17277)

Browse source 
parse_message_id() was improperly using a token defined inside an exception
handler, which was raising `UnboundLocalError` on parsing an invalid value.




https://bugs.python.org/issue38698
This commit is contained in:
Claudiu Popa 2019-12-05 04:14:26 +01:00 • committed by Miss Islington (bot)
parent 8b787964e0
commit bb815499af
3 changed files with 13 additions and 1 deletions
Download patch file Download diff file Expand all files Collapse all files

6
Lib/test/test_email/test__header_value_parser.py
View file

@ -2638,6 +2638,12 @@ class TestParser(TestParserMixin, TestEmailBase):
)
self.assertEqual(msg_id.token_type, 'msg-id')
def test_get_msg_id_invalid_expected_msg_id_not_found(self):
text = "Message-Id: 935-XPB-567:0:86089:180874:0:45327:9:90305:17843586-40@example.com"
msg_id = parser.parse_message_id(text)
self.assertDefectsEqual(msg_id.all_defects,
[errors.InvalidHeaderDefect])
def test_get_msg_id_no_angle_start(self):
with self.assertRaises(errors.HeaderParseError):
parser.get_msg_id("msgwithnoankle")