mirrors/cpython
1
0
Fork 0
mirror of https://github.com/python/cpython.git synced 2025-11-25 04:34:37 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 11

bpo-46841: Avoid unnecessary allocations in code object comparisons (GH-32222)

Browse source
This commit is contained in:
Brandt Bucher 2022-04-01 03:42:46 -07:00 • committed by GitHub
parent a0ea7a116c
commit bd2e47c883
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
2 changed files with 14 additions and 13 deletions
Download patch file Download diff file Expand all files Collapse all files

26
Objects/codeobject.c
View file

@ -1398,21 +1398,21 @@ code_richcompare(PyObject *self, PyObject *other, int op)
if (!eq) goto unequal;
eq = co->co_firstlineno == cp->co_firstlineno;
if (!eq) goto unequal;
PyObject *co_code = _PyCode_GetCode(co);
if (co_code == NULL) {
return NULL;
}
PyObject *cp_code = _PyCode_GetCode(cp);
if (cp_code == NULL) {
Py_DECREF(co_code);
return NULL;
}
eq = PyObject_RichCompareBool(co_code, cp_code, Py_EQ);
Py_DECREF(co_code);
Py_DECREF(cp_code);
if (eq <= 0) {
eq = Py_SIZE(co) == Py_SIZE(cp);
if (!eq) {
goto unequal;
}
for (int i = 0; i < Py_SIZE(co); i++) {
_Py_CODEUNIT co_instr = _PyCode_CODE(co)[i];
_Py_CODEUNIT cp_instr = _PyCode_CODE(cp)[i];
_Py_SET_OPCODE(co_instr, _PyOpcode_Deopt[_Py_OPCODE(co_instr)]);
_Py_SET_OPCODE(cp_instr, _PyOpcode_Deopt[_Py_OPCODE(cp_instr)]);
eq = co_instr == cp_instr;
if (!eq) {
goto unequal;
}
i += _PyOpcode_Caches[_Py_OPCODE(co_instr)];
}
/* compare constants */
consts1 = _PyCode_ConstantKey(co->co_consts);