mirrors/cpython
1
0
Fork 0
mirror of https://github.com/python/cpython.git synced 2025-08-04 00:48:58 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 8

bpo-29581: Make ABCMeta.__new__ pass **kwargs to type.__new__ (#527)

Browse source 
Many metaclasses in the standard library don't play nice with
__init_subclass__. This bug makes ABCMeta in particular with
__init_subclass__, which is an 80/20 solution for me personally.
AFAICT, a general solution to this problem requires updating all
metaclasses in the standard library to make sure they pass **kwargs to
type.__new__, whereas this PR only fixes ABCMeta. For context, see
https://bugs.python.org/issue29581.

* added a test combining ABCMeta and __init_subclass__
* Added NEWS item
This commit is contained in:
Nate 2017-03-15 11:39:22 -07:00 • committed by Łukasz Langa
parent b4e9087e7b
commit bd583ef985
3 changed files with 17 additions and 2 deletions
Download patch file Download diff file Expand all files Collapse all files

12
Lib/test/test_abc.py
View file

@ -404,5 +404,17 @@ class TestABC(unittest.TestCase):
self.assertEqual(B.counter, 1)
class TestABCWithInitSubclass(unittest.TestCase):
def test_works_with_init_subclass(self):
saved_kwargs = {}
class ReceivesClassKwargs:
def __init_subclass__(cls, **kwargs):
super().__init_subclass__()
saved_kwargs.update(kwargs)
class Receiver(ReceivesClassKwargs, abc.ABC, x=1, y=2, z=3):
pass
self.assertEqual(saved_kwargs, dict(x=1, y=2, z=3))
if __name__ == "__main__":
unittest.main()