mirrors/cpython
1
0
Fork 0
mirror of https://github.com/python/cpython.git synced 2025-09-26 18:29:57 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 10

Fix memory leaks in test_capi (#98017)

Browse source
This commit is contained in:
Carl Meyer 2022-10-07 08:17:41 -07:00 • committed by GitHub
parent f99bb20cde
commit be4099e55d
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
2 changed files with 6 additions and 0 deletions
Download patch file Download diff file Expand all files Collapse all files

3
Lib/test/test_capi.py
View file

@ -1495,6 +1495,9 @@ class TestDictWatchers(unittest.TestCase):
unraisable = unraisables[0] unraisable = unraisables[0]
self.assertIs(unraisable.object, d) self.assertIs(unraisable.object, d)
self.assertEqual(str(unraisable.exc_value), "boom!") self.assertEqual(str(unraisable.exc_value), "boom!")
# avoid leaking reference cycles
del unraisable
del unraisables
def test_two_watchers(self): def test_two_watchers(self):
d1 = {} d1 = {}

3
Modules/_testcapimodule.c
View file

@ -5210,6 +5210,7 @@ dict_watch_callback(PyDict_WatchEvent event,
Py_DECREF(msg); Py_DECREF(msg);
return -1; return -1;
} }
Py_DECREF(msg);
return 0; return 0;
} }
@ -5224,8 +5225,10 @@ dict_watch_callback_second(PyDict_WatchEvent event,
return -1; return -1;
} }
if (PyList_Append(g_dict_watch_events, msg) < 0) { if (PyList_Append(g_dict_watch_events, msg) < 0) {
Py_DECREF(msg);
return -1; return -1;
} }
Py_DECREF(msg);
return 0; return 0;
} }