GH-134584: Remove redundant refcount from _STORE_ATTR_SLOT (#142729)

2025-12-23 09:19:18 +00:00 · 2025-12-15 15:18:44 -08:00 · 2025-12-15 15:18:44 -08:00 · bef63d2fb8
commit bef63d2fb8
parent f277781bba
9 changed files with 70 additions and 17 deletions
--- a/Python/bytecodes.c
+++ b/Python/bytecodes.c
@ -2640,7 +2640,7 @@ dummy_func(
            _GUARD_TYPE_VERSION +
            _STORE_ATTR_WITH_HINT;

-        op(_STORE_ATTR_SLOT, (index/1, value, owner --)) {
+        op(_STORE_ATTR_SLOT, (index/1, value, owner -- o)) {
            PyObject *owner_o = PyStackRef_AsPyObjectBorrow(owner);

            DEOPT_IF(!LOCK_OBJECT(owner_o));
@ -2649,14 +2649,16 @@ dummy_func(
            PyObject *old_value = *(PyObject **)addr;
            FT_ATOMIC_STORE_PTR_RELEASE(*(PyObject **)addr, PyStackRef_AsPyObjectSteal(value));
            UNLOCK_OBJECT(owner_o);
-            PyStackRef_CLOSE(owner);
+            INPUTS_DEAD();
+            o = owner;
            Py_XDECREF(old_value);
        }

        macro(STORE_ATTR_SLOT) =
            unused/1 +
            _GUARD_TYPE_VERSION +
-            _STORE_ATTR_SLOT;
+            _STORE_ATTR_SLOT +
+            POP_TOP;

        family(COMPARE_OP, INLINE_CACHE_ENTRIES_COMPARE_OP) = {
            COMPARE_OP_FLOAT,