mirrors/cpython
1
0
Fork 0
mirror of https://github.com/python/cpython.git synced 2025-08-03 16:39:00 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 8

Issue #26309: Shut down socketserver request if verify_request() is false

Browse source 
Patch by Aviv Palivoda.
This commit is contained in:
Martin Panter 2016-02-18 10:43:55 +00:00
parent 8f0432ffbb
commit c12fef9aa3
3 changed files with 30 additions and 0 deletions
Download patch file Download diff file Expand all files Collapse all files

24
Lib/test/test_socketserver.py
View file

@ -280,6 +280,30 @@ class SocketServerTest(unittest.TestCase):
socketserver.TCPServer((HOST, -1),
socketserver.StreamRequestHandler)
def test_shutdown_request_called_if_verify_request_false(self):
# Issue #26309: BaseServer should call shutdown_request even if
# verify_request is False
shutdown_called = False
class MyServer(socketserver.TCPServer):
def verify_request(self, request, client_address):
return False
def shutdown_request(self, request):
nonlocal shutdown_called
shutdown_called = True
super().shutdown_request(request)
def connect_to_server(proto, addr):
s = socket.socket(proto, socket.SOCK_STREAM)
s.connect(addr)
s.close()
self.run_server(MyServer,
socketserver.StreamRequestHandler,
connect_to_server)
self.assertEqual(shutdown_called, True)
class MiscTestCase(unittest.TestCase):