mirrors/cpython
1
0
Fork 0
mirror of https://github.com/python/cpython.git synced 2025-09-27 02:39:58 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 13

bpo-36613: call remove_done_callback if exception (GH-12800)

Browse source 
Call remove_done_callback() in finally block.


https://bugs.python.org/issue36613
This commit is contained in:
gescheit 2019-05-03 18:18:02 +03:00 • committed by Miss Islington (bot)
parent 4461d704e2
commit c1964e9e21
2 changed files with 3 additions and 1 deletions
Download patch file Download diff file Expand all files Collapse all files

3
Lib/asyncio/tasks.py
View file

@ -495,10 +495,11 @@ async def _wait(fs, timeout, return_when, loop):
finally: finally:
if timeout_handle is not None: if timeout_handle is not None:
timeout_handle.cancel() timeout_handle.cancel()
for f in fs:
f.remove_done_callback(_on_completion)
done, pending = set(), set() done, pending = set(), set()
for f in fs: for f in fs:
f.remove_done_callback(_on_completion)
if f.done(): if f.done():
done.add(f) done.add(f)
else: else:

1
Misc/NEWS.d/next/Library/2019-04-12-13-52-15.bpo-36613.hqT1qn.rst Normal file
View file

@ -0,0 +1 @@
Fix :mod:`asyncio` wait() not removing callback if exception