mirrors/cpython
1
0
Fork 0
mirror of https://github.com/python/cpython.git synced 2025-11-08 21:52:45 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 8

gh-117613: Argument Clinic: disallow defining class parameter at module level (#117950)

Browse source
This commit is contained in:
neonene 2024-04-18 05:43:29 +09:00 • committed by GitHub
parent a4b44d39cd
commit c1d7147c82
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
2 changed files with 11 additions and 0 deletions
Download patch file Download diff file Expand all files Collapse all files

9
Lib/test/test_clinic.py
View file

@ -2518,6 +2518,15 @@ class ClinicParserTest(TestCase):
p = function.parameters['cls'] p = function.parameters['cls']
self.assertEqual(p.kind, inspect.Parameter.POSITIONAL_ONLY) self.assertEqual(p.kind, inspect.Parameter.POSITIONAL_ONLY)
def test_disallow_defining_class_at_module_level(self):
err = "A 'defining_class' parameter cannot be defined at module level."
block = """
module m
m.func
cls: defining_class
"""
self.expect_failure(block, err, lineno=2)
class ClinicExternalTest(TestCase): class ClinicExternalTest(TestCase):
maxDiff = None maxDiff = None

2
Tools/clinic/libclinic/dsl_parser.py
View file

@ -1102,6 +1102,8 @@ class DSLParser:
fail("A 'defining_class' parameter cannot have a default value.") fail("A 'defining_class' parameter cannot have a default value.")
if self.group: if self.group:
fail("A 'defining_class' parameter cannot be in an optional group.") fail("A 'defining_class' parameter cannot be in an optional group.")
if self.function.cls is None:
fail("A 'defining_class' parameter cannot be defined at module level.")
kind = inspect.Parameter.POSITIONAL_ONLY kind = inspect.Parameter.POSITIONAL_ONLY
else: else:
fail("A 'defining_class' parameter, if specified, must either " fail("A 'defining_class' parameter, if specified, must either "