mirrors/cpython
1
0
Fork 0
mirror of https://github.com/python/cpython.git synced 2025-10-21 22:22:48 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 8

Close #19494: add urrlib.request.HTTPBasicPriorAuthHandler

Browse source 
This auth handler adds the Authorization header to the first
HTTP request rather than waiting for a HTTP 401 Unauthorized
response from the server as the default HTTPBasicAuthHandler
does.

This allows working with websites like https://api.github.com which do
not follow the strict interpretation of RFC, but more the dicta in the
end of section 2 of RFC 2617:

    > A client MAY preemptively send the corresponding Authorization
    > header with requests for resources in that space without receipt
    > of another challenge from the server.  Similarly, when a client
    > sends a request to a proxy, it may reuse a userid and password in
    > the Proxy-Authorization header field without receiving another
    > challenge from the proxy server. See section 4 for security
    > considerations associated with Basic authentication.

Patch by Matej Cepl.
This commit is contained in:
Nick Coghlan 2014-11-12 23:33:50 +10:00
parent ab14088141
commit c216c48699
5 changed files with 53 additions and 0 deletions
Download patch file Download diff file Expand all files Collapse all files

15
Lib/test/test_urllib2.py
View file

@ -1422,6 +1422,21 @@ class HandlerTests(unittest.TestCase):
handler.do_open(conn, req)
self.assertTrue(conn.fakesock.closed, "Connection not closed")
def test_auth_prior_handler(self):
pwd_manager = MockPasswordManager()
pwd_manager.add_password(None, 'https://example.com',
'somebody', 'verysecret')
auth_prior_handler = urllib.request.HTTPBasicPriorAuthHandler(
pwd_manager)
http_hand = MockHTTPSHandler()
opener = OpenerDirector()
opener.add_handler(http_hand)
opener.add_handler(auth_prior_handler)
req = Request("https://example.com")
opener.open(req)
self.assertNotIn('Authorization', http_hand.httpconn.req_headers)
class MiscTests(unittest.TestCase):