mirror of
https://github.com/python/cpython.git
synced 2025-07-19 01:05:26 +00:00
Fix the internals of our hash functions to used unsigned values during hash
computation as the overflow behavior of signed integers is undefined. NOTE: This change is smaller compared to 3.2 as much of this cleanup had already been done. I added the comment that my change in 3.2 added so that the code would match up. Otherwise this just adds or synchronizes appropriate UL designations on some constants to be pedantic. In practice we require compiling everything with -fwrapv which forces overflow to be defined as twos compliment but this keeps the code cleaner for checkers or in the case where someone has compiled it without -fwrapv or their compiler's equivalent. Found by Clang trunk's Undefined Behavior Sanitizer (UBSan). Cleanup only - no functionality or hash values change.
This commit is contained in:
commit
c2176e46d7
4 changed files with 12 additions and 12 deletions
|
@ -11008,7 +11008,7 @@ static Py_hash_t
|
|||
unicode_hash(PyObject *self)
|
||||
{
|
||||
Py_ssize_t len;
|
||||
Py_uhash_t x;
|
||||
Py_uhash_t x; /* Unsigned for defined overflow behavior. */
|
||||
|
||||
#ifdef Py_DEBUG
|
||||
assert(_Py_HashSecret_Initialized);
|
||||
|
|
Loading…
Add table
Add a link
Reference in a new issue