mirrors/cpython
1
0
Fork 0
mirror of https://github.com/python/cpython.git synced 2025-10-01 21:02:15 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 8

Fix a bug in Generic.__new__ (GH-6758)

Browse source 
(cherry picked from commit b551e9f0ff)

Co-authored-by: Ivan Levkivskyi <levkivskyi@gmail.com>
This commit is contained in:
Miss Islington (bot) 2018-05-10 20:30:47 -07:00 • committed by GitHub
parent 22df4187c3
commit c5444b3556
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
2 changed files with 4 additions and 1 deletions
Download patch file Download diff file Expand all files Collapse all files

3
Lib/test/test_typing.py
View file

@ -1367,6 +1367,9 @@ class GenericTests(BaseTestCase):
class A(Generic[T]): class A(Generic[T]):
pass pass
with self.assertRaises(TypeError):
A('foo')
class B: class B:
def __new__(cls): def __new__(cls):
# call object # call object

2
Lib/typing.py
View file

@ -836,7 +836,7 @@ class Generic:
if cls is Generic: if cls is Generic:
raise TypeError("Type Generic cannot be instantiated; " raise TypeError("Type Generic cannot be instantiated; "
"it can be used only as a base class") "it can be used only as a base class")
if super().__new__ is object.__new__: if super().__new__ is object.__new__ and cls.__init__ is not object.__init__:
obj = super().__new__(cls) obj = super().__new__(cls)
else: else:
obj = super().__new__(cls, *args, **kwds) obj = super().__new__(cls, *args, **kwds)