mirrors/cpython
1
0
Fork 0
mirror of https://github.com/python/cpython.git synced 2025-09-26 18:29:57 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 10

[3.12] gh-122695: Fix double-free when using gc.get_referents with a freed _asyncio.FutureIter (#122837) (#122859)

Browse source 
[3.13] gh-122695: Fix double-free when using `gc.get_referents` with a freed `_asyncio.FutureIter` (#122837)

* Backport #122834 for 3.13

(cherry picked from commit e8fb088dba)

Co-authored-by: Peter Bierma <zintensitydev@gmail.com>
This commit is contained in:
Victor Stinner 2024-08-09 16:33:24 +02:00 • committed by GitHub
parent c536f59c62
commit c57a33d006
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
3 changed files with 10 additions and 8 deletions
Download patch file Download diff file Expand all files Collapse all files

8
Lib/test/test_asyncio/test_futures.py
View file

@ -641,6 +641,14 @@ class CFutureTests(BaseFutureTests, test_utils.TestCase):
with self.assertRaises(AttributeError):
del fut._log_traceback
def test_future_iter_get_referents_segfault(self):
# See https://github.com/python/cpython/issues/122695
import _asyncio
it = iter(self._new_future(loop=self.loop))
del it
evil = gc.get_referents(_asyncio)
gc.collect()
@unittest.skipUnless(hasattr(futures, '_CFuture'),
'requires the C _asyncio module')

2
Misc/NEWS.d/next/Library/2024-08-08-15-05-58.gh-issue-122695.f7pwBv.rst Normal file
View file

@ -0,0 +1,2 @@
Fixed double-free when using :func:`gc.get_referents` with a freed
:class:`asyncio.Future` iterator.

8
Modules/_asynciomodule.c
View file

@ -3606,14 +3606,6 @@ module_traverse(PyObject *mod, visitproc visit, void *arg)
Py_VISIT(state->iscoroutine_typecache);
Py_VISIT(state->context_kwname);
// Visit freelist.
PyObject *next = (PyObject*) state->fi_freelist;
while (next != NULL) {
PyObject *current = next;
Py_VISIT(current);
next = (PyObject*) ((futureiterobject*) current)->future;
}
return 0;
}