mirrors/cpython
1
0
Fork 0
mirror of https://github.com/python/cpython.git synced 2025-07-09 20:35:26 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 11

gh-125519: Improve traceback if importlib.reload() is called with a non-module object (#125520)

Browse source
This commit is contained in:
Alex Waygood 2024-10-21 07:53:21 +01:00 • committed by GitHub
parent 9256be7ff0
commit c5c21fee7a
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
3 changed files with 18 additions and 1 deletions
Download patch file Download diff file Expand all files Collapse all files

15
Lib/test/test_importlib/test_api.py
View file

@ -9,6 +9,7 @@ import sys
from test import support
from test.support import import_helper
from test.support import os_helper
import traceback
import types
import unittest
@ -354,6 +355,20 @@ class ReloadTests:
with self.assertRaises(ModuleNotFoundError):
self.init.reload(module)
def test_reload_traceback_with_non_str(self):
# gh-125519
with support.captured_stdout() as stdout:
try:
self.init.reload("typing")
except TypeError as exc:
traceback.print_exception(exc, file=stdout)
else:
self.fail("Expected TypeError to be raised")
printed_traceback = stdout.getvalue()
self.assertIn("TypeError", printed_traceback)
self.assertNotIn("AttributeError", printed_traceback)
self.assertNotIn("module.__spec__.name", printed_traceback)
(Frozen_ReloadTests,
Source_ReloadTests