mirrors/cpython
1
0
Fork 0
mirror of https://github.com/python/cpython.git synced 2025-11-02 03:01:58 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 15

bpo-37406: sqlite3 raises TypeError for wrong operation type (GH-14386)

Browse source 
The sqlite3 module now raises TypeError, rather than ValueError, if
operation argument type is not str: execute(), executemany() and
calling a connection.
This commit is contained in:
Victor Stinner 2019-06-26 03:16:24 +02:00 • committed by GitHub
parent ed076ed467
commit c6a2320e87
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
6 changed files with 11 additions and 16 deletions
Download patch file Download diff file Expand all files Collapse all files

4
Lib/sqlite3/test/dbapi.py
View file

@ -230,7 +230,7 @@ class CursorTests(unittest.TestCase):
""")
def CheckExecuteWrongSqlArg(self):
with self.assertRaises(ValueError):
with self.assertRaises(TypeError):
self.cu.execute(42)
def CheckExecuteArgInt(self):
@ -377,7 +377,7 @@ class CursorTests(unittest.TestCase):
self.cu.executemany("insert into test(income) values (?)", mygen())
def CheckExecuteManyWrongSqlArg(self):
with self.assertRaises(ValueError):
with self.assertRaises(TypeError):
self.cu.executemany(42, [(3,)])
def CheckExecuteManySelect(self):

2
Lib/sqlite3/test/regression.py
View file

@ -261,7 +261,7 @@ class RegressionTests(unittest.TestCase):
Call a connection with a non-string SQL request: check error handling
of the statement constructor.
"""
self.assertRaises(sqlite.Warning, self.con, 1)
self.assertRaises(TypeError, self.con, 1)
def CheckCollation(self):
def collation_cb(a, b):