mirrors/cpython
1
0
Fork 0
mirror of https://github.com/python/cpython.git synced 2025-11-25 12:44:13 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 11

gh-127146: Emscripten: more regular stack overflow skips (#136708)

Browse source 
Makes the Emscripten stack overflow skip message consistent with WASI, 
and replaces some ad-hoc skips.
This commit is contained in:
Hood Chatham 2025-07-16 16:02:25 +02:00 • committed by GitHub
parent 12e52cad71
commit c730952aa6
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
3 changed files with 3 additions and 3 deletions
Download patch file Download diff file Expand all files Collapse all files

2
Lib/test/support/__init__.py
View file

@ -570,7 +570,7 @@ is_emscripten = sys.platform == "emscripten"
is_wasi = sys.platform == "wasi"
def skip_emscripten_stack_overflow():
return unittest.skipIf(is_emscripten, "Exhausts limited stack on Emscripten")
return unittest.skipIf(is_emscripten, "Exhausts stack on Emscripten")
def skip_wasi_stack_overflow():
return unittest.skipIf(is_wasi, "Exhausts stack on WASI")

2
Lib/test/test_descr.py
View file

@ -3942,7 +3942,7 @@ class ClassPropertiesAndMethods(unittest.TestCase):
# it as a leak.
del C.__del__
@unittest.skipIf(support.is_emscripten, "Seems to works in Pyodide?")
@support.skip_emscripten_stack_overflow()
@support.skip_wasi_stack_overflow()
def test_slots_trash(self):
# Testing slot trash...

2
Lib/test/test_xml_etree_c.py
View file

@ -58,7 +58,7 @@ class MiscTests(unittest.TestCase):
self.assertEqual(element.attrib, {'A': 'B', 'C': 'D'})
@support.skip_wasi_stack_overflow()
@unittest.skipIf(support.is_emscripten, "segfaults")
@support.skip_emscripten_stack_overflow()
def test_trashcan(self):
# If this test fails, it will most likely die via segfault.
e = root = cET.Element('root')