mirrors/cpython
1
0
Fork 0
mirror of https://github.com/python/cpython.git synced 2025-08-03 08:34:29 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 6

gh-99553: fix bug where an ExceptionGroup subclass can wrap a BaseException (GH-99572)

Browse source
This commit is contained in:
Irit Katriel 2022-11-18 15:44:43 +00:00 • committed by GitHub
parent a220c6d1ee
commit c8c6113398
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
4 changed files with 37 additions and 5 deletions
Download patch file Download diff file Expand all files Collapse all files

14
Objects/exceptions.c
View file

@ -753,7 +753,19 @@ BaseExceptionGroup_new(PyTypeObject *type, PyObject *args, PyObject *kwds)
}
}
else {
/* Do nothing - we don't interfere with subclasses */
/* user-defined subclass */
if (nested_base_exceptions) {
int nonbase = PyObject_IsSubclass((PyObject*)cls, PyExc_Exception);
if (nonbase == -1) {
goto error;
}
else if (nonbase == 1) {
PyErr_Format(PyExc_TypeError,
"Cannot nest BaseExceptions in '%.200s'",
cls->tp_name);
goto error;
}
}
}
if (!cls) {