mirrors/cpython
1
0
Fork 0
mirror of https://github.com/python/cpython.git synced 2025-09-26 18:29:57 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 10

part of #3613: fix get_host_info() usage of base64.encodestring().

Browse source
This commit is contained in:
Georg Brandl 2009-02-13 10:50:01 +00:00
parent 35e2c4e67a
commit c8dcfb6cec
2 changed files with 10 additions and 1 deletions
Download patch file Download diff file Expand all files Collapse all files

8
Lib/test/test_xmlrpc.py
View file

@ -135,6 +135,14 @@ class XMLRPCTestCase(unittest.TestCase):
xmlrpclib.loads(strg)[0][0]) xmlrpclib.loads(strg)[0][0])
self.assertRaises(TypeError, xmlrpclib.dumps, (arg1,)) self.assertRaises(TypeError, xmlrpclib.dumps, (arg1,))
def test_get_host_info(self):
# see bug #3613, this raised a TypeError
transp = xmlrpc.client.Transport()
self.assertEquals(transp.get_host_info("user@host.tld"),
('host.tld',
[('Authorization', 'Basic dXNlcg==')], {}))
class HelperTestCase(unittest.TestCase): class HelperTestCase(unittest.TestCase):
def test_escape(self): def test_escape(self):
self.assertEqual(xmlrpclib.escape("a&b"), "a&b") self.assertEqual(xmlrpclib.escape("a&b"), "a&b")

3
Lib/xmlrpc/client.py
View file

@ -1161,7 +1161,8 @@ class Transport:
if auth: if auth:
import base64 import base64
auth = base64.encodestring(urllib.parse.unquote(auth)) auth = urllib.parse.unquote_to_bytes(auth)
auth = base64.encodestring(auth).decode("utf-8")
auth = "".join(auth.split()) # get rid of whitespace auth = "".join(auth.split()) # get rid of whitespace
extra_headers = [ extra_headers = [
("Authorization", "Basic " + auth) ("Authorization", "Basic " + auth)