mirrors/cpython
1
0
Fork 0
mirror of https://github.com/python/cpython.git synced 2025-08-31 05:58:33 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 7

Be smarter about clearing the weakref lists for instances, instance methods,

Browse source 
and functions: we only need to call PyObject_ClearWeakRefs() if the weakref
list is non-NULL.  Since these objects are common but weakrefs are still
unusual, saving the call at deallocation time makes a lot of sense.
This commit is contained in:
Fred Drake 2001-10-26 17:56:51 +00:00
parent 7408da54e2
commit c916f5a390
2 changed files with 6 additions and 3 deletions
Download patch file Download diff file Expand all files Collapse all files

6
Objects/classobject.c
View file

@ -585,7 +585,8 @@ instance_dealloc(register PyInstanceObject *inst)
extern long _Py_RefTotal;
#endif
_PyObject_GC_UNTRACK(inst);
PyObject_ClearWeakRefs((PyObject *) inst);
if (inst->in_weakreflist != NULL)
PyObject_ClearWeakRefs((PyObject *) inst);
/* Temporarily resurrect the object. */
#ifdef Py_TRACE_REFS
@ -2071,7 +2072,8 @@ static void
instancemethod_dealloc(register PyMethodObject *im)
{
_PyObject_GC_UNTRACK(im);
PyObject_ClearWeakRefs((PyObject *)im);
if (im->im_weakreflist != NULL)
PyObject_ClearWeakRefs((PyObject *)im);
Py_DECREF(im->im_func);
Py_XDECREF(im->im_self);
Py_XDECREF(im->im_class);

3
Objects/funcobject.c
View file

@ -270,7 +270,8 @@ static void
func_dealloc(PyFunctionObject *op)
{
_PyObject_GC_UNTRACK(op);
PyObject_ClearWeakRefs((PyObject *) op);
if (op->func_weakreflist != NULL)
PyObject_ClearWeakRefs((PyObject *) op);
Py_DECREF(op->func_code);
Py_DECREF(op->func_globals);
Py_DECREF(op->func_name);