mirrors/cpython
1
0
Fork 0
mirror of https://github.com/python/cpython.git synced 2025-08-19 08:11:46 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 8

Backport 58332: Fix Coverity #159.

Browse source 
This code was broken if save() returned a negative number since i contained
a boolean value and then we compared i < 0 which should never be true.
This commit is contained in:
Neal Norwitz 2007-10-05 05:05:24 +00:00
parent 14f848bb22
commit c9f22b954f
1 changed files with 1 additions and 1 deletions
Download patch file Download diff file Expand all files Collapse all files

2
Modules/cPickle.c
View file

@ -2249,7 +2249,7 @@ save_reduce(Picklerobject *self, PyObject *args, PyObject *ob)
Py_INCREF(temp);
PyTuple_SET_ITEM(newargtup, i-1, temp);
}
i = save(self, newargtup, 0) < 0;
i = save(self, newargtup, 0);
Py_DECREF(newargtup);
if (i < 0)
return -1;