mirrors/cpython
1
0
Fork 0
mirror of https://github.com/python/cpython.git synced 2025-09-30 04:15:43 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 11

[3.6] bpo-30584: Fix test_os fails on non-English Windows (GH-1980) (#1999)

Browse source 
* Fix bpo-30584

* Adding a comment mentionning the bpo and explaining what is the identifier

* Add Denis Osipov to Misc/ACKS
(cherry picked from commit 897bba7563)
This commit is contained in:
Denis Osipov 2017-06-08 17:02:05 +05:00 • committed by Victor Stinner
parent 854f7ba1d5
commit ca1b66fd05
2 changed files with 4 additions and 1 deletions
Download patch file Download diff file Expand all files Collapse all files

4
Lib/test/test_os.py
View file

@ -473,7 +473,9 @@ class StatAttributeTests(unittest.TestCase):
# force CreateFile to fail with ERROR_ACCESS_DENIED. # force CreateFile to fail with ERROR_ACCESS_DENIED.
DETACHED_PROCESS = 8 DETACHED_PROCESS = 8
subprocess.check_call( subprocess.check_call(
['icacls.exe', fname, '/deny', 'Users:(S)'], # bpo-30584: Use security identifier *S-1-5-32-545 instead
# of localized "Users" to not depend on the locale.
['icacls.exe', fname, '/deny', '*S-1-5-32-545:(S)'],
creationflags=DETACHED_PROCESS creationflags=DETACHED_PROCESS
) )
result = os.stat(fname) result = os.stat(fname)

1
Misc/ACKS
View file

@ -1121,6 +1121,7 @@ William Orr
Michele Orrù Michele Orrù
Tomáš Orsava Tomáš Orsava
Oleg Oshmyan Oleg Oshmyan
Denis Osipov
Denis S. Otkidach Denis S. Otkidach
Peter Otten Peter Otten
Michael Otteneder Michael Otteneder